Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with convert_culled_mesh_to_cdf5 for hurricane test case #726

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Fixed issue with convert_culled_mesh_to_cdf5 for hurricane test case #726

merged 4 commits into from
Nov 8, 2023

Conversation

gcapodag
Copy link
Collaborator

@gcapodag gcapodag commented Nov 8, 2023 •
edited by xylar
Loading

This PR fixes this error:

configparser.NoOptionError: No option 'convert_culled_mesh_to_cdf5' in section: 'spherical_mesh'

when running the cull mesh step for themesh_lts hurricane test case.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • The E3SM-Project submodule has been updated with relevant E3SM changes
  • The MALI-Dev submodule has been updated with relevant MALI changes
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes
  • New tests have been added to a test suite

closes #725

@xylar
Copy link
Collaborator

xylar commented Nov 8, 2023

@gcapodag, this isn't passing pre-commit. Could you change the top of the configure.py file to this?

from compass.ocean.tests.global_ocean.metadata import (
    get_author_and_email_from_git,
)

@xylar xylar self-assigned this Nov 8, 2023
@xylar xylar added bug Something isn't working ocean labels Nov 8, 2023
@gcapodag
Copy link
Collaborator Author

gcapodag commented Nov 8, 2023

Flake8 is complaining about this: F821 undefined name 'spherical_mesh' on hurricane.cfg

@xylar
Copy link
Collaborator

xylar commented Nov 8, 2023

Okay, linting is good now.

@xylar
Copy link
Collaborator

xylar commented Nov 8, 2023

Flake8 is complaining about this: F821 undefined name 'spherical_mesh' on hurricane.cfg

I don't think you should be using flake8 on non-python files. If you set up a compass conda environment, it installs pre-commit and (assuming you have the conda environment active where you edit code) that will lint the files for you before you commit changes.

@gcapodag
Copy link
Collaborator Author

gcapodag commented Nov 8, 2023

I didn't know, thanks @xylar

@xylar xylar merged commit 5327d22 into MPAS-Dev:main Nov 8, 2023
4 checks passed
@gcapodag gcapodag deleted the hurrican_cfg_fix branch November 8, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xylar xylar xylar approved these changes

Assignees

@xylar xylar

Labels
bug Something isn't working ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

configparser error on mesh_lts hurricane test
2 participants
@gcapodag @xylar